Patchwork [STABLE] tests: disable test of buffer overflow in parsers.c if --pure

login
register
mail settings
Submitter Yuya Nishihara
Date July 19, 2015, 6:58 a.m.
Message ID <6e79dc5971e7d5f2aaa2.1437289132@mimosa>
Download mbox | patch
Permalink /patch/10041/
State Accepted
Headers show

Comments

Yuya Nishihara - July 19, 2015, 6:58 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1437287248 -32400
#      Sun Jul 19 15:27:28 2015 +0900
# Branch stable
# Node ID 6e79dc5971e7d5f2aaa290b1ca4a8308484ee88d
# Parent  a2d178b3a1b4227e5e7d48d2b3fa5ab1171ca59b
tests: disable test of buffer overflow in parsers.c if --pure

It fails with AttributeError and there's no benefit to make it runnable
with pure Python code.
Matt Mackall - July 20, 2015, 8:56 p.m.
On Sun, 2015-07-19 at 15:58 +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1437287248 -32400
> #      Sun Jul 19 15:27:28 2015 +0900
> # Branch stable
> # Node ID 6e79dc5971e7d5f2aaa290b1ca4a8308484ee88d
> # Parent  a2d178b3a1b4227e5e7d48d2b3fa5ab1171ca59b
> tests: disable test of buffer overflow in parsers.c if --pure

Queued for default, thanks.

Patch

diff --git a/tests/hghave.py b/tests/hghave.py
--- a/tests/hghave.py
+++ b/tests/hghave.py
@@ -376,3 +376,7 @@  def has_absimport():
 @check("py3k", "running with Python 3.x")
 def has_py3k():
     return 3 == sys.version_info[0]
+
+@check("pure", "running with pure Python code")
+def has_pure():
+    return os.environ.get("HGTEST_RUN_TESTS_PURE") == "--pure"
diff --git a/tests/test-parseindex.t b/tests/test-parseindex.t
--- a/tests/test-parseindex.t
+++ b/tests/test-parseindex.t
@@ -62,6 +62,8 @@  We approximate that by reducing the read
 
 Test corrupted p1/p2 fields that could cause SEGV at parsers.c:
 
+#if no-pure
+
   $ mkdir invalidparent
   $ cd invalidparent
 
@@ -118,3 +120,5 @@  Test corrupted p1/p2 fields that could c
   find_deepest: parent out of range
 
   $ cd ..
+
+#endif